Opened 3 years ago

Closed 3 years ago

#12695 closed Bug report (fixed)

Edited files not saving back to server

Reported by: David Lohnes Owned by:
Priority: normal Component: FileZilla Client
Keywords: view edit no window Cc: JGonz, lexiconnect
Component version: 3.59.0 Operating system type: Windows
Operating system version: 10 Enterprise v. 21H2 OS Build 19044.1586

Description

When I click View/Edit a file on the server it opens in Notepad++ for me. When I edit the file and save, it does not save back to the server. However, when I close Filezilla it asks me if I really want to quit. Whatever I answer it pops up the File has changed window and will save the file to the server. I just updated to 3.59.0 this morning and this started happening.

Change History (13)

comment:1 by JGonz, 3 years ago

Cc: JGonz added

Hi, seconding that.

Behavior before v3.59:
I "View/Edit" a text file in FileZilla, it opens in my EditPadPro. After making some changes I save it.
A few seconds later FileZilla pops a dialog asking what to do with the changes.

Behavior after v3.59:
I "View/Edit" a text file in FileZilla, it opens in my EditPadPro. After making some changes I save it.
FileZilla doesn't do anything anymore. I must do a "Ctrl-E" now to sync the file to the server.
Looks like Filzilla doesn't monitor the file anymore - which is a major hassle!

There have been no changes in EditPadPro recently. The change in behavior correlates with my update to Filezilla 3.59.
Maybe there's a new setting now that changes the previous behavior?
"Watch locally edited files" in "Settings/File Editing" is checked.

Thx for your great work, have fun!

My System: FileZilla Client


Version: 3.59.0

Build information:

Compiled for: x86_64-w64-mingw32
Compiled on: x86_64-pc-linux-gnu
Build date: 2022-04-08
Compiled with: x86_64-w64-mingw32-gcc (GCC) 10-win32 20210110
Compiler flags: -O2 -g -Wall -Wextra -Wno-deprecated-copy -ffunction-sections -fdata-sections -Wno-cast-function-type

Linked against:

wxWidgets: 3.0.6
SQLite: 3.35.5
GnuTLS: 3.7.2

Operating system:

Name: Windows 10 (build 19044), 64-bit edition
Version: 10.0
Platform: 64-bit system
CPU features: sse sse2 sse3 ssse3 sse4.1 sse4.2 pclmulqdq lm
Settings dir: C:\Users\XYZ\AppData\Roaming\FileZilla\

comment:2 by torf23, 3 years ago

Same Problem, but I realized that when I close Notepad++ FileZilla reacts to changes made.

If I only save the local file without closing Notepad++ it does not ask for reupload the changed file.

comment:3 by lexiconnect, 3 years ago

Same issue here with Notepad++, when closing Notepad++ Filezilla realises there is a change and asks to upload, problem is you then lose the ability to undo any changes in Notepad++

comment:4 by lexiconnect, 3 years ago

Cc: lexiconnect added

comment:5 by chris, 3 years ago

Same happening here using 3.59.0

Editing with Notepad ++ used to prompt the upload after saving the file, its been sporadic at best.

I didn't know about Ctrl+E for seeing edited files and forcing an upload, thats a good work around for now - better than copying the file locally each time.

Please can we get a fix on this? It dramatically slows down the speed I can work.

comment:6 by chris, 3 years ago

FileZilla Client


Version: 3.59.0

Build information:

Compiled for: x86_64-w64-mingw32
Compiled on: x86_64-pc-linux-gnu
Build date: 2022-04-08
Compiled with: x86_64-w64-mingw32-gcc (GCC) 10-win32 20210110
Compiler flags: -O2 -g -Wall -Wextra -Wno-deprecated-copy -ffunction-sections -fdata-sections -Wno-cast-function-type

Linked against:

wxWidgets: 3.0.6
SQLite: 3.35.5
GnuTLS: 3.7.2

Operating system:

Name: Windows 10 (build 19044), 64-bit edition
Version: 10.0
Platform: 64-bit system
CPU features: sse sse2 sse3 ssse3 sse4.1 sse4.2 avx avx2 aes pclmulqdq rdrnd bmi bmi2 lm
Settings dir: C:\Users\Chris\AppData\Roaming\FileZilla\

comment:7 by norbie, 3 years ago

I have the same issue except I use Notepad2 as a text editor within Windows, I'm using FileZilla 3.59.0 on Windows 10 64-bit.

Previously after saving the file, I'd get a prompt to upload the updated file almost straight away.

I get this prompt only after the first save.

After this, it only prompts to upload again after closing the text editor.

Previously it would prompt after every save whilst the editor was open.

This problem did not occur before the recent update.

Last edited 3 years ago by norbie (previous) (diff)

comment:8 by lexiconnect, 3 years ago

Discovered this by accident, but it seems to not be an issue for me if both editor and filezilla are on the same monitor (ie in a 3 screen setup, which is not usually something I do).

comment:9 by bookcat123, 3 years ago

I thought at first that mine was doing the same since the last update - never saving the file unless and until I closed it - but I've realized it's actually a combination of two things:

  1. Filezilla needs to be the active window to notice a file has been saved and pop-up the option to save to the server. This is not new, and not a big deal until it is combined with point 2:
  1. The act of clicking anywhere within the Filezilla window cancels the save pop-up. This is new. Previously, I could edit in Notepad++, save, then click on Filezilla for the save prompt. Now, I can only click on either the icon in my start bar or the Filezilla title bar. If I click anywhere else on the Filezilla window, I will never be given the option to save the file.
Last edited 3 years ago by bookcat123 (previous) (diff)

comment:10 by JGonz, 3 years ago

Hi,
tested some more & got a reasonable workaround (based on bookcat123's post above):

  1. 'View/Edit' a file on the FTP
  2. Change it's content & save in the external editor.

=> Notice that NOW FileZilla should pop it's 'File has changed' window - but it doesn't.

  1. Activate FileZilla via a click on the taskbar icon, a click of it's windows title bar, or via 'Alt-Tab' - it will pop it's 'File has changed' window :)

If in step 3 you click somewhere else inside FileZillas window (beside the title bar) it will NOT pop the 'File has changed' window. But if you just go back to your editor, then again activate FileZilla via one of the ways described in #3, voila, there it is :)

I tested with windows on the same monitor or on different monitors (as lexiconnect reported) but found no difference.

Notice that before v3.59 FileZilla monitored the 'view/edited' file continuously, even while in background, and reacted quickly, as soon as the file was saved - this was a very handy feature.
Not having it anymore (or in this much less useful form) has already caused some trouble (not saving back the change due to distraction/ scatterbrain ...).

Pretty please, have a look at this!

Version 0, edited 3 years ago by JGonz (next)

comment:11 by JGonz, 3 years ago

Hi,

tested some more & got a reasonable workaround (based on bookcat123's post above):

  1. 'View/Edit' a file on the FTP
  2. Change it's content & save in the external editor.

=> Notice that NOW FileZilla should pop it's 'File has changed' window - but it doesn't.

  1. Activate FileZilla via a click on the taskbar icon, a click of it's windows title bar, or via 'Alt-Tab' - it will pop it's 'File has changed' window :)

If in step 3 you click somewhere else inside FileZillas window (beside the title bar) it will NOT pop the 'File has changed' window. But if you just go back to your editor, then again activate FileZilla via one of the ways described in step 3, voila, there it is :)

I tested with windows on the same monitor or on different monitors (as lexiconnect reported) but found no difference.

Notice that before v3.59 FileZilla monitored the 'view/edited' file continuously, even while in background, and reacted quickly, as soon as the file was saved - this was a very handy feature.
Not having it anymore (or in this much less useful form) has already caused some trouble (not saving back the change due to distraction/ scatterbrain ...).

Pretty please, have a look at this!

comment:12 by smess, 3 years ago

Same experience as bookcat123 and JGonz. Using EditPlus on Windows 10.

After editing & saving a local file, clicking on the FileZilla taskbar icon or title bar triggers the expected upload pop-up.

Clicking on the body of the FileZilla window after editing *does not* trigger the upload pop-up and clicking taskbar or title bar still does not produce the pop-up.

So it would appear that clicking on the body of the FileZilla window dismisses the pop-up before it can be seen.

comment:13 by Tim Kosse, 3 years ago

Resolution: fixed
Status: newclosed

Issue will be fixed in the next version of FileZilla.

Note: See TracTickets for help on using tickets.