Custom Query (8174 matches)

HP-UX 11.X has an annoying habit of putting function or macro declarations of the same functions in more than one system header file and then documenting which header file to include in the man page, dependent on the compiler flags you use. Yes, it is barmy and, unfortunately, ntohs() is one of those functions.

"man ntohs" says that #include <netinet/in.h> should be used to declare the ntohs() function *unless* _XOPEN_SOURCE_EXTENDED is defined, in which case #include <arpa/inet.h> is included instead. I've been compiling the FileZilla Client 3.1.6 with -D_XOPEN_SOURCE_EXTENDED in HP-UX 11.X, so the #include <netinet/in.h> in src/engine/socket.cpp isn't good enough to declare ntohs(). Here's a fix I inserted just above the include in src/engine/socket.cpp (line 24 or so):

#if defined(hpux) && defined(_XOPEN_SOURCE_EXTENDED)

#include <arpa/inet.h>

#endif #include <netinet/in.h>

You may find a more elegant way to do this (e.g. if all systems have <arpa/inet.h>, you might not need the defined(hpux) bit).

When compiling FileZilla Client 3.1.6 in HP-UX 11.X, there are a fair number of fussy compiler warnings from HP's C++ compiler (plus a link failure that I've documented in a separate bug). I've attached the output from the build so that you can look through the warnings and decide if any of them need fixing (the trailing comma in an enum warning is an easy fix). The output is from a PA-RISC HP-UX 11.11 machine using HP's latest C++ compiler (A.03.85) and is after I've fixed any build issues mentioned in the recent bugs I filed for HP-UX 11.X.

A downloading FileZilla client crashes and loses the download queue on my friend's computer when I restart my computer which runs the FileZilla server application he is connected to. Last time the crash situation included an "Illegal operation" Windows error.